Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read receipts are not sent when the app is in background (WPB-8756) #3488

Open
wants to merge 2 commits into
base: release/candidate
Choose a base branch
from
Open

fix: read receipts are not sent when the app is in background (WPB-8756) #3488

wants to merge 2 commits into from
+6 −4

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 8, 2024 •
edited by github-actions bot
Loading

BugWPB-8756 [Android] Read receipts not generated when responding from notification popup

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR will adapt the changes applied in this PR wireapp/kalium#3054

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 8, 2024
@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, mchenani, Garzas and mathias-niboulies and removed request for a team and mathias-niboulies October 8, 2024 12:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.43%. Comparing base (2d37412) to head (b5d5a35).
Report is 29 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...on/broadcastreceivers/NotificationReplyReceiver.kt 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                  @@
##           release/candidate    #3488      +/-   ##
=====================================================
- Coverage              44.59%   44.43%   -0.16%     
=====================================================
  Files                    467      466       -1     
  Lines                  15785    15745      -40     
  Branches                2656     2653       -3     
=====================================================
- Hits                    7039     6996      -43     
- Misses                  7989     7992       +3     
  Partials                 757      757
Files with missing lines Coverage Δ
...on/broadcastreceivers/NotificationReplyReceiver.kt 3.57% <0.00%> (-0.14%) ⬇️

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d37412...b5d5a35. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3488.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3488.apk is available for download

@yamilmedina yamilmedina changed the base branch from develop to release/candidate October 16, 2024 11:02
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale Inactivity alert label Nov 16, 2024
@github-actions github-actions bot removed the stale Inactivity alert label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
DO NOT MERGE echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @codecov-commenter @yamilmedina @Garzas